Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add timeout to session.get() in get_all_by_isin() function #1879

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add timeout to session.get() in get_all_by_isin() function #1879

wants to merge 1 commit into from

Conversation

ahnazary
Copy link

@ahnazary ahnazary commented Mar 6, 2024

Related to this issue

@ValueRaider
Copy link
Collaborator

Instead, can get_all_by_isin be refactored to use YfData? Is a singleton so easy. Feel free to reduce timeout, there's no particular reason for 30.

Also can you target dev branch? #1084

@ValueRaider
Copy link
Collaborator

Paging @ahnazary ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahnazary @ValueRaider